Skip to content

fix flaky tests #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 7, 2018
Merged

fix flaky tests #530

merged 5 commits into from
Dec 7, 2018

Conversation

jesterhazy
Copy link
Contributor

@jesterhazy jesterhazy commented Dec 6, 2018

Description of changes:

  • fix flaky tests
  • run pylint concurrently
  • use raw string (r'...') for a regex
  • remove out of date comment

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jesterhazy jesterhazy requested a review from nadiaya December 6, 2018 20:05
nadiaya
nadiaya previously approved these changes Dec 6, 2018
@jesterhazy jesterhazy changed the title minor code cleanup fix flaky tests Dec 7, 2018
@codecov-io
Copy link

Codecov Report

Merging #530 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
+ Coverage    92.7%   92.83%   +0.12%     
==========================================
  Files          71       71              
  Lines        5336     5343       +7     
==========================================
+ Hits         4947     4960      +13     
+ Misses        389      383       -6
Impacted Files Coverage Δ
src/sagemaker/tensorflow/serving.py 98.33% <ø> (ø) ⬆️
src/sagemaker/fw_utils.py 100% <100%> (ø) ⬆️
src/sagemaker/utils.py 93.02% <100%> (+0.4%) ⬆️
src/sagemaker/local/image.py 89.6% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b1be7...27ec8ba. Read the comment docs.

Copy link
Contributor

@laurenyu laurenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to whoever merges this: I think #502 can be closed then

Copy link
Contributor

@yangaws yangaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants